[Fleet + Integrations UI] Address UI Regressions in Fleet/Integrations #102250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpollich
added
v8.0.0
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @kpollich |
majagrubic
pushed a commit
to majagrubic/kibana
that referenced
this pull request
Jun 18, 2021
elastic#102250) * Fix active tabs in integrations UI Fixes elastic#101771 * Remove duplicate base breadcrumb Fixes elastic#101785 * Fix i18n
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kpollich
added a commit
to kpollich/kibana
that referenced
this pull request
Jun 21, 2021
elastic#102250) * Fix active tabs in integrations UI Fixes elastic#101771 * Remove duplicate base breadcrumb Fixes elastic#101785 * Fix i18n
kibanamachine
removed
the
backport missing
kpollich
added a commit
that referenced
this pull request
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses two bugs that followed after migrating the Integrations UI to a separate Kibana app in #99848
Fixes #101771
Fixes #101785
Active Tab State in Integrations UI
Integrations tabs now properly display active state based on the current tab.
Screen Recording
Duplicate Breadcrumbs on Integrations Pages
We no longer display
Integrations > Integrationson initial load, reducing UI shift for the breadcrumbs.Screen Recording